Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use APIConvID #45

Merged
merged 6 commits into from Jan 15, 2020
Merged

use APIConvID #45

merged 6 commits into from Jan 15, 2020

Conversation

joshblum
Copy link
Member

@joshblum joshblum commented Jan 9, 2020 •
edited

@joshblum joshblum requested a review from mmaxim January 9, 2020 22:51
@joshblum joshblum mentioned this pull request Jan 10, 2020
Merged
1 task
@joshblum joshblum force-pushed the joshblum/api-types-HOTPOT-1652 branch from f7dc21f to 9b2a92a Compare January 10, 2020 20:49
@joshblum joshblum force-pushed the joshblum/api-types-HOTPOT-1652 branch from 9b2a92a to 4139f26 Compare January 13, 2020 20:00
@mmaxim
Copy link
Collaborator

mmaxim commented Jan 13, 2020

Can we s/APIConvID/ConversationIDStr or something?

@joshblum joshblum merged commit 884889a into master Jan 15, 2020
@joshblum joshblum deleted the joshblum/api-types-HOTPOT-1652 branch January 15, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmaxim mmaxim mmaxim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshblum @mmaxim